feat(function): add greatest function #12474
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This match the Spark implementation for greatest: https://spark.apache.org/docs/latest/api/python/reference/pyspark.sql/api/pyspark.sql.functions.greatest.html
|
FYI #12357 (comment) |
|
Related to #6531 |
Hey @alamb, we talked about the test location at the beginning of the CMU talk you gave, where the tests are located? |
|
I think the tests I was talking about are described here: If you want to test the type of a function you can do it like select arrow_typeif(my_func(foo))) |
|
I see, thank you, how is your experience with debugging this kind of test? |
|
It is great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #12472
Rationale for this change
Support more operators
What changes are included in this PR?
Implement the Spark implementation for
greatest:https://spark.apache.org/docs/latest/api/python/reference/pyspark.sql/api/pyspark.sql.functions.greatest.html
Are these changes tested?
I was not able to find where you put the functions test, the
coalescefor example has only one test for the return type, I must missing somethingdatafusion/datafusion/functions/src/core/coalesce.rs
Lines 142 to 157 in 7bd7747
Are there any user-facing changes?
Yes, I need to add documentation, but first check if this feature is desired